Fix remove and exist with _id type different of ObjectId #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Could you please add a test to prevent regression errors in the future? Thanks |
|
yes, I will do. |
| if (options._id) { | ||
| _id = this.tryParseObjectId(options._id) || options._id; | ||
| options._id = this.tryParseObjectId(options._id) || options._id; |
There was a problem hiding this comment.
You are now mutating the options object passed in, this is considered a bad practice and can lead to some hard to track down bugs...
There was a problem hiding this comment.
Ok, you're right. I fixed the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.